Repository navigation
feat(core): Support SuppressedError in LinkedErrors integration - #25246
Merged
timfish merged 6 commits intoOct 14, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Closed
Collaborator
…-suppressed-error
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 91c0b88. Configure here.
Contributor
Author
|
thanks @timfish, I've added an integration test at suites/public-api/suppressed-error. It uses |
kunal649
commented
Oct 14, 2026
timfish
approved these changes
Oct 14, 2026
timfish
enabled auto-merge (squash)
October 14, 2026 17:53
nicohrubec
pushed a commit
that referenced
this pull request
Oct 15, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #25246 Co-authored-by: timfish <1150298+timfish@users.noreply.github.com>
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuppressedErroris what JS throws when a cleanup (using/Symbol.dispose) fails while another error is already in flight. It keeps both errors,error(the new one) andsuppressed(the original), and it has nocause. because of that, LinkedErrors never saw them. In Sentry I only got the generic wrapper message, "An error was suppressed during disposal".Take a look , how it looks today (node SDK):
This change makes
aggregateExceptionsFromErroralso followerrorandsuppressed, the same way it already followscauseanderrors[], both errors now show up as chained exceptions. If a SuppressedError has another SuppressedError inside, it goes down the chain too.And one thing I'm not sure about: I did not set
is_exception_groupon the wrapper. From #10850 i understand that flag makes sentry ignore that entry for grouping and titles, and that was a problem forcauseerrors. But the wrapper here has a meaningless message, so maybe it should be a group. (happy to change it if you prefer.)I added tests for both errors, nested SuppressedErrors, non-Error values, and an error that only has an
errorproperty (it must not be treated as a SuppressedError).Fixes #8441